Skip to content

V2 TO V3 fragment changes for extension and server directory under test/.. #12058

Merged
junr03 merged 4 commits intoenvoyproxy:masterfrom
ankatare:v2_to_v3_fragment_changes_extensions_directory
Jul 31, 2020
Merged

V2 TO V3 fragment changes for extension and server directory under test/.. #12058
junr03 merged 4 commits intoenvoyproxy:masterfrom
ankatare:v2_to_v3_fragment_changes_extensions_directory

Conversation

@ankatare
Copy link
Copy Markdown
Contributor

@ankatare ankatare commented Jul 13, 2020 •
edited
Loading

Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Additional Description:
Risk Level: Low
Testing: unit and format
Docs Changes:NA
Release Notes: NA
[Optional Runtime guard:]
Optional Fixes #10843
[Optional Deprecated:]

@junr03 junr03 self-assigned this Jul 13, 2020
@ankatare ankatare force-pushed the v2_to_v3_fragment_changes_extensions_directory branch from e9f94ea to 937e11d Compare July 14, 2020 07:21
@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 14, 2020

@junr03 seems some env issues in this PR.
https://dev.azure.com/cncf/envoy/_build/results?buildId=44878&view=results

please suggest if it is good to go with code review.

@junr03
Copy link
Copy Markdown
Member

junr03 commented Jul 18, 2020

Try merging master again?

@ankatare ankatare force-pushed the v2_to_v3_fragment_changes_extensions_directory branch from 937e11d to 7a61a59 Compare July 18, 2020 08:37
@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 18, 2020

@junr03 ok.

@ankatare
V2 TO V3 fragment changes for extension and server directory under test/
588b1aa 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare ankatare force-pushed the v2_to_v3_fragment_changes_extensions_directory branch from 7a61a59 to 588b1aa Compare July 19, 2020 08:16
@ankatare
fixing build issues
58696bc 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 20, 2020

@junr03 merged from master. again seems some different env issues. please suggest if it is ok to review code.

@junr03
Copy link
Copy Markdown
Member

junr03 commented Jul 20, 2020

@ankatare looks like a valid clang-tidy failure. Not because of your change. The file was already invalid, but changing it made it so that clang-tidy ran over it and detected already existing failures. Do you mind fixing?

@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 20, 2020

@junr03 sure, please suggest how to fix it , any pointers would be helpful.

@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 21, 2020

@junr03 i tried below command to fix issue
clang-tidy -fix-errors -checks='readability-identifier-naming' test/extensions/filters/network/thrift_proxy/filters/ratelimit/ratelimit_test.cc.
That fixes clang-tidy error. but while unit testing it with bazel test it is failing locally.
would you please suggest what to do as in this case as i can't push test file now.

@junr03
Copy link
Copy Markdown
Member

junr03 commented Jul 23, 2020

@ankatare what is the failure trace?

@ankatare ankatare force-pushed the v2_to_v3_fragment_changes_extensions_directory branch 4 times, most recently from fad74c0 to 951c1df Compare July 24, 2020 06:39
@ankatare
fixing clang-tidy
6c96003 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare ankatare force-pushed the v2_to_v3_fragment_changes_extensions_directory branch from 951c1df to 6c96003 Compare July 24, 2020 11:33
@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 24, 2020

@junr03 Build completed with master in sync and resolved clang-tidy issues. please review.

@ankatare ankatare mentioned this pull request Jul 30, 2020
Closed
@junr03 junr03 merged commit ae0c311 into envoyproxy:master Jul 31, 2020
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
@ankatare
V2 TO V3 fragment changes for extension and server directory under te…
eda6652 
…st/.. (envoyproxy#12058)

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Risk Level: Low
Testing: unit and format
Fixes envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
@ankatare
V2 TO V3 fragment changes for extension and server directory under te…
1548eb0 
…st/.. (envoyproxy#12058)

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Risk Level: Low
Testing: unit and format
Fixes envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssawilk alyssawilk Awaiting requested review from alyssawilk

@lizan lizan Awaiting requested review from lizan

@mattklein123 mattklein123 Awaiting requested review from mattklein123

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

@snowp snowp Awaiting requested review from snowp

@zuercher zuercher Awaiting requested review from zuercher

1 more reviewer

@junr03 junr03 junr03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@junr03 junr03

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert v2 API test fragments to v3

2 participants

@ankatare @junr03