Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
snowp
approved these changes
Jul 13, 2020
lizan
added a commit
that referenced
this pull request
Jul 14, 2020
- fix coverage number missed by #12054 Signed-off-by: Lizan Zhou <lizan@tetrate.io>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
- fix coverage number missed by envoyproxy#12054 Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating coverage numbers from a fresh run of coverage.dat and (annoyingly for the diff) changing the order to that spit out by the script.
(hopefully) bringing up coverage of the retry predicates so they can be removed from the list.
Risk Level: n/a
Testing: new tests
Docs Changes: n/a
Release Notes: n/a