build: Remove chromium_url#12023
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Jul 10, 2020
dio:remove-chromium_url
Merged
build: Remove chromium_url#12023htuch merged 2 commits intoenvoyproxy:masterfrom dio:remove-chromium_url
htuch merged 2 commits intoenvoyproxy:masterfrom
dio:remove-chromium_url
Conversation
This removes chromium_url Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
lizan
approved these changes
Jul 10, 2020
Member
lizan
left a comment
There was a problem hiding this comment.
Nice! @htuch or @alyssawilk for non-Tetrate approval.
htuch
approved these changes
Jul 10, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
Fantastic, this is so amazing! CC @yanavlasov @asraa @antoniovicente @adisuissa
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
This removes chromium_url in favor of GURL. Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Fixes: envoyproxy#6588 Signed-off-by: Dhi Aurrahman <dio@tetrate.io> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This removes
chromium_urlin favor ofGURL.Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Fixes: #6588.
Signed-off-by: Dhi Aurrahman dio@tetrate.io