test: refactor header inclusion to speed up building#11952
Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom Jul 8, 2020
Merged
test: refactor header inclusion to speed up building#11952ggreenway merged 1 commit intoenvoyproxy:masterfrom
ggreenway merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Muge Chen <mugechen@google.com>
ahedberg
approved these changes
Jul 8, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ggreenway
approved these changes
Jul 8, 2020
Member
ggreenway
left a comment
There was a problem hiding this comment.
Looks good. Thanks for working on this.
The CI failure looks like a flake; it compiled, so I don't think this PR could be the cause.
This was referenced Jul 9, 2020
Closed
Merged
Merged
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muge Chen mugechen@google.com
Refactor mock class include directive after dividing test/server/mocks.h (#11649)
Building time comparison for affected tests:
Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
\cc @ahedberg