Subject: Porting Envoy to C++17 #11570#11941

Merged

mattklein123 merged 37 commits intoenvoyproxy:masterfrom

Jul 15, 2020

Contributor

aimless404 commented Jul 7, 2020

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

This PR is created after the commit history of #11570 has become too noisy to be useful. This is just my attempt to start clean and is exactly the same as the previous PR #11570

Commit Message: This is to continue the process of porting Envoy to C++17. It aims to set the foundation for the improved readability when Envoy codebase can start to utilize a various of features of C++17.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Yifan Yang added 23 commits

June 26, 2020 15:24


          Subject: porting Envoy to C++17

d5644c4

Signed-off-by: Yifan Yang <needyyang@google.com>


          Subject: fixing the CI builds

b8462a2

Signed-off-by: Yifan Yang <needyyang@google.com>


          fix of a bug (loss of precision when doing implicit conversion)

b38c8d9

Signed-off-by: Yifan Yang <needyyang@google.com>


          added compiler flag to silence incorrect MSVC warning

1b35238

Signed-off-by: Yifan Yang <needyyang@google.com>


          trying to see if adding external dep in build solves linker issue

93991ef

Signed-off-by: Yifan Yang <needyyang@google.com>


          another attempt to fix msvc linkage problems

Signed-off-by: Yifan Yang <needyyang@google.com>


          trying one last time

09d2ed6

Signed-off-by: Yifan Yang <needyyang@google.com>


          fixing the windows ci and get rid of the warnings

07a5d44

Signed-off-by: Yifan Yang <needyyang@google.com>


          api builds fix

f477318

Signed-off-by: Yifan Yang <needyyang@google.com>


          trying to fix api ci

807d4c3

Signed-off-by: Yifan Yang <needyyang@google.com>


          does this fix ci problem

f7726fd

Signed-off-by: Yifan Yang <needyyang@google.com>


          get rid of the separate c++14 flag added to clang_tools.bzl

713e306

Signed-off-by: Yifan Yang <needyyang@google.com>


          getting rid of unnecessary c++ flag

da4c5cc

Signed-off-by: Yifan Yang <needyyang@google.com>


          getting rid of unnecessary c++ flag

c9c2799

Signed-off-by: Yifan Yang <needyyang@google.com>


          getting ready for submission

6a7a254

Signed-off-by: Yifan Yang <needyyang@google.com>


          add macos flag

16f981f

Signed-off-by: Yifan Yang <needyyang@google.com>


          add the flag to macos build

89e1872

Signed-off-by: Yifan Yang <needyyang@google.com>


          fixing macos c++17 flag

9423af5

Signed-off-by: Yifan Yang <needyyang@google.com>


          adding the flags in envoy_internal.bzl back because they are failing …

5c0b94f

…the windows and macOS build

Signed-off-by: Yifan Yang <needyyang@google.com>


          to force the rerun of CI

711507a

Signed-off-by: Yifan Yang <needyyang@google.com>


          revert the change manually

1fb2976

Signed-off-by: Yifan Yang <needyyang@google.com>


          manually revert the patches

3d39125

Signed-off-by: Yifan Yang <needyyang@google.com>


          manually revert the patch changes

38b3d65

Signed-off-by: Yifan Yang <needyyang@google.com>

aimless404 requested review from jmarantz, mattklein123, snowp and zuercher as code owners

July 7, 2020 23:09


          Merge branch 'master' of github.com:envoyproxy/envoy into PR2

4b016bd

Contributor

yanavlasov commented Jul 8, 2020

You may need to merge master to see if it clears the Linux-x64 compile_time_options build. However it looks like windows compiler is not happy building QUICHE with the options you have specified. This may need to be fixed upstream in QUICHE @danzh2010

yanavlasov self-assigned this


          silence the incorrect unused return value warning

4c69a00

Signed-off-by: Yifan Yang <needyyang@google.com>

Contributor Author

aimless404 commented Jul 8, 2020

@yanavlasov Windows build should be fine once the quiche tar is updated (I tested it locally by applying a manual patch).

danzh2010 mentioned this pull request

quiche: update tar #11964

Merged


          getting rid of the duplicate flags

49b22cb

Signed-off-by: Yifan Yang <needyyang@google.com>

Contributor Author

aimless404 commented Jul 10, 2020

/azp run envoy-presubmit

azure-pipelines bot commented Jul 10, 2020

Commenter does not have sufficient privileges for PR 11941 in repo envoyproxy/envoy

Yifan Yang added 5 commits

July 10, 2020 17:09


          rerun the CI

f699973

Signed-off-by: Yifan Yang <needyyang@google.com>


          rerun the CI

a79eab1

Signed-off-by: Yifan Yang <needyyang@google.com>


          rerun the CI

Signed-off-by: Yifan Yang <needyyang@google.com>


          Merge branch 'master' of github.com:envoyproxy/envoy into PR2

3dcc3c9


          fix gcc compiler warning

a4ff870

Signed-off-by: Yifan Yang <needyyang@google.com>

Contributor

yanavlasov commented Jul 11, 2020

/azp run envoy-presubmit

azure-pipelines bot commented Jul 11, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Yifan Yang added 2 commits

July 11, 2020 00:57


          previous run was failing a flaky test

b550468

Signed-off-by: Yifan Yang <needyyang@google.com>


          more flaky tests

576f5d7

Signed-off-by: Yifan Yang <needyyang@google.com>

Contributor Author

aimless404 commented Jul 11, 2020

@yanavlasov It finally passes all the checks

Yifan Yang added 3 commits

July 13, 2020 15:21


          a workaround on the behavorial difference between gcc and clang

0e22d6e

Signed-off-by: Yifan Yang <needyyang@google.com>


          previous CI results in weird abrupted status

19cb152

Signed-off-by: Yifan Yang <needyyang@google.com>


          Merge branch 'master' of github.com:envoyproxy/envoy into PR2

6c255f0

Contributor Author

aimless404 commented Jul 13, 2020

@htuch Do you mind taking a look?

htuch reviewed

View reviewed changes

bazel/cel-cpp.patch Outdated Show resolved Hide resolved


          use the updated upstream to remove the duplicates in cel-cpp patch

e4aa7be

Signed-off-by: Yifan Yang <needyyang@google.com>

aimless404 requested a review from htuch

July 15, 2020 13:30

htuch approved these changes

View reviewed changes

Member

htuch left a comment

LGTM, thanks!

mattklein123 merged commit 42a4b9f into envoyproxy:master

aimless404 mentioned this pull request

Subject: changing the C++17 build flag envoyproxy/envoy-mobile#964

Merged

asraa mentioned this pull request

build: upgrade to C++17 #9091

Closed

KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request


          Subject: Porting Envoy to C++17 envoyproxy#11570 (envoyproxy#11941)

fc1b062

Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>

scheler pushed a commit to scheler/envoy that referenced this pull request


          Subject: Porting Envoy to C++17 envoyproxy#11570 (envoyproxy#11941)

68b7ff8

Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jmarantz Awaiting requested review from jmarantz

mattklein123 Awaiting requested review from mattklein123

snowp Awaiting requested review from snowp

zuercher Awaiting requested review from zuercher

1 more reviewer

htuch htuch approved these changes

Labels

None yet