android: Disable getifaddrs call for old NDK versions#11863
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 14, 2020
Merged
Conversation
`getifaddrs` and `freeifaddrs` were added in Android NDK API version 24. This patch skips that logic, as was being done for WIN32, if that's your target version. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
|
I think the test failure is unrelated |
lizan
reviewed
Jul 6, 2020
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
lizan
approved these changes
Jul 9, 2020
This was referenced Jul 9, 2020
Member
Author
|
The CI failures look unrelated here: |
This was referenced Jul 14, 2020
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 15, 2020
We can do this now that envoyproxy/envoy#11863 has landed and upstream has been bumped. Resolves #936. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 15, 2020
We can do this now that envoyproxy/envoy#11863 has landed and upstream has been bumped. Resolves #936. Signed-off-by: Michael Rebello <me@michaelrebello.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
`getifaddrs` and `freeifaddrs` were added in Android NDK API version 24. This patch skips that logic, as was being done for WIN32, if that's your target version. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
We can do this now that #11863 has landed and upstream has been bumped. Resolves envoyproxy/envoy-mobile#936. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
We can do this now that #11863 has landed and upstream has been bumped. Resolves envoyproxy/envoy-mobile#936. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getifaddrsandfreeifaddrswere added in Android NDK API version 24.This patch skips that logic, as was being done for WIN32, if that's your
target version.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com