Ratelimit: Add dynamic metadata to ratelimit actions#11723
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jun 26, 2020
Merged
Ratelimit: Add dynamic metadata to ratelimit actions#11723mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Modifies ratelimit filter to be able to use information from the dynamic metadata as one of its actions Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
htuch
reviewed
Jun 24, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
API looks good modulo a tiny nit. Can you also update docs/root/version_history/current.rst? Thanks.
Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
mattklein123
requested changes
Jun 25, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome work, thank you! Just a few small comments.
/wait
Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
Contributor
|
/retest |
|
🤷♀️ nothing to rebuild. |
Member
|
@Pchelolo @clarakosi merging master probably would help. |
Member
|
TSAN failure is a known issue, will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Modifies ratelimit filter to be able to use information
from the dynamic metadata as one of its actions.
Signed-off-by: Clara Andrew-Wani candrewwani@gmail.com
Risk Level:
Testing: unit tests
Docs Changes: Updated rate limit actions to now include dynamic metadata
Release Notes:
Fixes #11593