Skip to content

docker, examples: Use tagged alpine image#11680

Merged
asraa merged 1 commit intoenvoyproxy:masterfrom
dio:alpine-3.12
Jun 23, 2020
Merged

docker, examples: Use tagged alpine image#11680
asraa merged 1 commit intoenvoyproxy:masterfrom
dio:alpine-3.12

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Jun 22, 2020

Commit Message:

This patch updates alpine-based images to use the tagged images (alpine-3.12_glibc-2.31) instead of using latest. Since the latest change in frolvlad/alpine-glibc for python3 package, examples are also updated to use py3-pip instead of python3 for bootstrapping Flask.

Additional Description:

The latest frolvlad/alpine-glibc is tagged using alpine-3.12 as its base, in which the pip3 is no longer packed inside the python3 package. Instead, we
should use the py3-pip (https://pkgs.alpinelinux.org/contents?branch=v3.12&name=py3-pip&arch=x86_64&repo=community) package.

alpine-3.11 packs pip3 inside the python3 package: https://pkgs.alpinelinux.org/contents?branch=v3.11&name=python3&arch=x86_64&repo=main,
which is no longer true for alpine-3.12: https://pkgs.alpinelinux.org/contents?branch=v3.12&name=python3&arch=x86_64&repo=main

Risk Level: Low (updating alpine-based image, examples-only)
Testing: Manual
Docs Changes: N/A
Release Notes: N/A

Fixes #11679

Signed-off-by: Dhi Aurrahman dio@tetrate.io

The latest frolvlad/alpine-glibc is tagged using alpine-3.12, in which
the pip3 is no longer packed inside the python3 package. Insted, we
should use the py3-pip
(https://pkgs.alpinelinux.org/contents?branch=v3.12&name=py3-pip&arch=x86_64&repo=community)
package.

alpine-3.11 packs pip3 inside the python3 package: https://pkgs.alpinelinux.org/contents?branch=v3.11&name=python3&arch=x86_64&repo=main,
which is no longer true for alpine-3.12: https://pkgs.alpinelinux.org/contents?branch=v3.12&name=python3&arch=x86_64&repo=main

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asraa for non-Tetrands review

@asraa asraa merged commit ff1f312 into envoyproxy:master Jun 23, 2020
songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020
The latest frolvlad/alpine-glibc is tagged using alpine-3.12, in which
the pip3 is no longer packed inside the python3 package. Insted, we
should use the py3-pip
(https://pkgs.alpinelinux.org/contents?branch=v3.12&name=py3-pip&arch=x86_64&repo=community)
package.

alpine-3.11 packs pip3 inside the python3 package: https://pkgs.alpinelinux.org/contents?branch=v3.11&name=python3&arch=x86_64&repo=main,
which is no longer true for alpine-3.12: https://pkgs.alpinelinux.org/contents?branch=v3.12&name=python3&arch=x86_64&repo=main

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
The latest frolvlad/alpine-glibc is tagged using alpine-3.12, in which
the pip3 is no longer packed inside the python3 package. Insted, we
should use the py3-pip
(https://pkgs.alpinelinux.org/contents?branch=v3.12&name=py3-pip&arch=x86_64&repo=community)
package.

alpine-3.11 packs pip3 inside the python3 package: https://pkgs.alpinelinux.org/contents?branch=v3.11&name=python3&arch=x86_64&repo=main,
which is no longer true for alpine-3.12: https://pkgs.alpinelinux.org/contents?branch=v3.12&name=python3&arch=x86_64&repo=main

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Front-proxy example error == returned a non-zero code: 127

3 participants