Skip to content

Fix missing instantiation of parameterized tests for redis cluster#11545

Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
HenryYYang:updateIntegration
Jun 25, 2020
Merged

Fix missing instantiation of parameterized tests for redis cluster#11545
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
HenryYYang:updateIntegration

Conversation

@HenryYYang
Copy link
Copy Markdown
Contributor

Commit Message: Fix missing instantiation of parameterized tests for redis cluster
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Fixes #11246

Signed-off-by: Henry Yang <hyang@lyft.com>
Signed-off-by: Henry Yang <hyang@lyft.com>
@HenryYYang HenryYYang requested a review from mattklein123 as a code owner June 10, 2020 22:37
@mattklein123 mattklein123 self-assigned this Jun 10, 2020
@stale
Copy link
Copy Markdown

stale bot commented Jun 18, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 18, 2020
Signed-off-by: Henry Yang <hyang@lyft.com>
Signed-off-by: Henry Yang <hyang@lyft.com>
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 25, 2020
@mattklein123 mattklein123 changed the title [WIP] Fix missing instantiation of parameterized tests for redis cluster Fix missing instantiation of parameterized tests for redis cluster Jun 25, 2020
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 45c7d87 into envoyproxy:master Jun 25, 2020
songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
…nvoyproxy#11545)

Signed-off-by: Henry Yang <hyang@lyft.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] Some test/extensions/clusters/redis/redis_cluster_integration_test test cases not running due to missing INSTANTIATE_TEST_SUITE_P

2 participants