api: populate secure edge defaults manifest.#11364
Merged
htuch merged 7 commits intoenvoyproxy:masterfrom Jun 9, 2020
Merged
Conversation
Adding API annotations and manifest entries to match https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge. Risk level: Low (API/docs only change) Testing: Docs build and inspection. Fixes envoyproxy#11085 Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
reviewed
Jun 2, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, some comments to get started. Thank you!
/wait-any
| // response is initiated. If not specified or set to 0, this timeout is disabled. | ||
| google.protobuf.Duration request_timeout = 28; | ||
| google.protobuf.Duration request_timeout = 28 | ||
| [(udpa.annotations.security).configure_for_untrusted_downstream = true]; |
Member
There was a problem hiding this comment.
For streaming requests, it may not be possible to configure this. How should we handle this case?
Member
Author
There was a problem hiding this comment.
I have updated to use the new noting mechanism in the manifest.
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Jun 4, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
This is amazing! Just a small comment, thank you.
/wait
Signed-off-by: Harvey Tuch <htuch@google.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Adding API annotations and manifest entries to match https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge. Risk level: Low (API/docs only change) Testing: Docs build and inspection. Fixes envoyproxy#11085 Signed-off-by: Harvey Tuch <htuch@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Adding API annotations and manifest entries to match https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge. Risk level: Low (API/docs only change) Testing: Docs build and inspection. Fixes envoyproxy#11085 Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding API annotations and manifest entries to match https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge.
This patch also introduces support for proto-defined manifest format and moves the manifest away from being specific to edge default to being fully generic.
Risk level: Low (API/docs only change)
Testing: Docs build and inspection.
Fixes #11085
Signed-off-by: Harvey Tuch htuch@google.com