Skip to content

bazelci: add coverage#11218

Merged
lizan merged 1 commit intoenvoyproxy:masterfrom
lizan:bazelci_cov
May 15, 2020
Merged

bazelci: add coverage#11218
lizan merged 1 commit intoenvoyproxy:masterfrom
lizan:bazelci_cov

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented May 15, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@lizan lizan merged commit 466bd54 into envoyproxy:master May 15, 2020
@lizan lizan deleted the bazelci_cov branch May 15, 2020 22:37
htuch pushed a commit that referenced this pull request May 18, 2020
@meteorcloudy
Copy link
Copy Markdown
Contributor

Hi, there is some failures on Bazel CI after merging this.
https://buildkite.com/bazel/envoy/builds/1151

Is there already a fix coming in?

@lizan
Copy link
Copy Markdown
Member Author

lizan commented May 20, 2020

@meteorcloudy this doesn't fail in my local, what does the clang/llvm version installed in the CI image?

@meteorcloudy
Copy link
Copy Markdown
Contributor

So from the log;

The C compiler identification is Clang 9.0.0

@lizan
Copy link
Copy Markdown
Member Author

lizan commented May 20, 2020

@meteorcloudy that's from RBE, which is managed by our build-tools repo. But seems the local (i.e. where llvm-profdata runs, with --TestRunner=sandboxed,local) having different version of clang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants