grpc: adding limits to outbound buffered data for google-gRPC access logs#11072
Merged
htuch merged 6 commits intoenvoyproxy:masterfrom May 12, 2020
Merged
grpc: adding limits to outbound buffered data for google-gRPC access logs#11072htuch merged 6 commits intoenvoyproxy:masterfrom
htuch merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
htuch
reviewed
May 6, 2020
|
|
||
| * access loggers: added GRPC_STATUS operator on logging format. | ||
| * access loggers: applied existing buffer limits to the non-google gRPC access logs, as well as :ref:`stats <config_access_log_stats>` for logged / dropped logs. | ||
| * access loggers: applied existing buffer limits to access logs, as well as :ref:`stats <config_access_log_stats>` for logged / dropped logs. This can be reverted temporarily by setting runtime feature `envoy.reloadable_features.allow_unbounded_access_logs` to false. |
Member
There was a problem hiding this comment.
Should this be true? I.e. if we're adding default limits, do allow unbounded logs we should set that to true?
| initial_metadata_(config.initial_metadata()), scope_(scope) { | ||
| initial_metadata_(config.initial_metadata()), scope_(scope), | ||
| per_stream_buffer_limit_bytes_(PROTOBUF_GET_WRAPPED_OR_DEFAULT( | ||
| config.google_grpc(), per_stream_buffer_limit_bytes, 1024 * 1024)) { |
Member
There was a problem hiding this comment.
Nit: maybe make this a named constant.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
Should be merged up again. PTAL when you get a chance. |
htuch
reviewed
May 11, 2020
| // gRPC library. | ||
| google.protobuf.Struct config = 6; | ||
|
|
||
| // How many bytes each steam can buffer internally. |
| TestUtility::findCounter(stats_store_, "access_logs.grpc_access_log.logs_dropped")->value()); | ||
| } | ||
|
|
||
| TEST_F(GrpcAccessLoggerImplTest, WatermarksLegacy) { |
Member
There was a problem hiding this comment.
Why is this called legacy? Can you add a one liner // above this test to explain what it does?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium (changes by default)
Testing: new unit tests, new guard also tested
Docs Changes: n/a
Release Notes: yes
Optional Runtime guard: envoy.reloadable_features.allow_unbounded_access_logs
[Optional Fixes #Issue]
Fixes #10764