dynamic_forward_proxy: DNS Cache circuit breaker by Shikugawa · Pull Request #11028 · envoyproxy/envoy

Shikugawa · 2020-05-01T09:20:19Z

Signed-off-by: shikugawa rei@tetrate.io

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: In the current implementation of the DNS cache, circuit breaker is derived from cluster config. It seems unnatural. In this PR, I implemented the DNS cache specific circuit breaker by adding resource manager to that.
Additional Description:
Risk Level: Mid
Testing: Unit / Integration
Docs Changes: Required
Release Notes: Required
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only · 2020-05-01T16:54:03Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #11028 was synchronize by Shikugawa.

see: more, trace.

mattklein123

Flushing out a few API comments. Note that this will require documentation and release notes. We also need to figure out how to gracefully handle the existing use case. I think potentially if the new config is not set we should use the cluster circuit breaker for some period of time in the existing HTTP code. Need to discuss. Thank you!

/wait

api/envoy/config/cluster/v3/circuit_breaker.proto

Signed-off-by: shikugawa <rei@tetrate.io>

api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only · 2020-05-05T11:01:03Z

CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11028 was synchronize by Shikugawa.

see: more, trace.

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

A few API/doc comments to get started. Please also fix tidy. Thank you!

/wait

api/envoy/config/common/dynamic_forward_proxy/v2alpha/dns_cache.proto

api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

On the right track. Flushing out a few comments. Thank you!

/wait

api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto

docs/root/version_history/current.rst

source/extensions/common/dynamic_forward_proxy/dns_cache.h

source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc

api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto

source/extensions/common/dynamic_forward_proxy/dns_cache_resource_manager.h

source/extensions/filters/http/dynamic_forward_proxy/proxy_filter.cc

Signed-off-by: Shikugawa <rei@tetrate.io>

mattklein123

/wait

source/extensions/common/dynamic_forward_proxy/dns_cache.h

source/extensions/common/dynamic_forward_proxy/dns_cache_impl.cc

source/extensions/filters/http/dynamic_forward_proxy/proxy_filter.cc

Signed-off-by: Shikugawa <rei@tetrate.io>

mattklein123

LGTM modulo final nits, thanks!

/wait

source/extensions/common/dynamic_forward_proxy/dns_cache.h

Signed-off-by: Shikugawa <rei@tetrate.io>

mattklein123

Thanks!

lizan · 2020-06-30T21:25:47Z

@Shikugawa can you merge master? it conflicts with security patches.

Signed-off-by: Shikugawa <rei@tetrate.io>

Shikugawa · 2020-07-01T12:58:41Z

@lizan @mattklein123 Windows CI is failing. This seems that there is potential problems in Windows building.
https://dev.azure.com/cncf/envoy/_build/results?buildId=43639&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=168f295b-0553-5364-35f7-923225ecd8b3&l=3440

…-circuit-breaker Signed-off-by: Shikugawa <rei@tetrate.io>

Signed-off-by: Shikugawa <rei@tetrate.io>

Shikugawa added 2 commits May 1, 2020 09:15

init

6dc3f0e

Signed-off-by: shikugawa <rei@tetrate.io>

impl

855b379

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot added the api label May 1, 2020

mattklein123 assigned mattklein123 and lizan May 1, 2020

mattklein123 requested changes May 1, 2020

View reviewed changes

api/envoy/config/cluster/v3/circuit_breaker.proto Outdated Show resolved Hide resolved

api/envoy/config/cluster/v3/circuit_breaker.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label May 1, 2020

impl stats

3eac0c4

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label May 4, 2020

Shikugawa added 2 commits May 4, 2020 12:57

review

e898071

Signed-off-by: shikugawa <rei@tetrate.io>

fix test

65d9b03

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 reviewed May 4, 2020

View reviewed changes

api/envoy/extensions/common/dynamic_forward_proxy/v3/dns_cache.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label May 4, 2020

resource manager test

121ebd7

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label May 5, 2020

add circuit breaking checker

94ed978

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 added the waiting label May 5, 2020

fix

d77a679

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label May 7, 2020

Shikugawa marked this pull request as ready for review May 7, 2020 12:07

Shikugawa requested review from alyssawilk and lizan as code owners May 7, 2020 12:07

mattklein123 requested changes May 7, 2020

View reviewed changes

repokitteh-read-only bot added waiting v2-freeze labels May 7, 2020

fix

a8d7f74

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label May 13, 2020

mattklein123 requested changes May 13, 2020

View reviewed changes

mattklein123 added the waiting label Jun 25, 2020

fix

d065a10

Signed-off-by: Shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Jun 26, 2020

fix

d884a5f

Signed-off-by: Shikugawa <rei@tetrate.io>

mattklein123 requested changes Jun 26, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Jun 26, 2020

fix

bfd04c4

Signed-off-by: Shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Jun 29, 2020

mattklein123 requested changes Jun 29, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Jun 29, 2020

fix

f1fc7bb

Signed-off-by: Shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Jun 30, 2020

mattklein123 previously approved these changes Jun 30, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Jun 30, 2020

mattklein123 added the waiting label Jun 30, 2020

conflict

f9cc356

Signed-off-by: Shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Jul 1, 2020

fix

a5d361d

Signed-off-by: Shikugawa <rei@tetrate.io>

Shikugawa dismissed mattklein123’s stale review via a5d361d July 1, 2020 06:12

repokitteh-read-only bot added the api label Jul 1, 2020

Shikugawa added 2 commits July 1, 2020 07:20

Kick CI

587f3c1

Signed-off-by: Shikugawa <rei@tetrate.io>

Kick CI

4838e6a

Signed-off-by: Shikugawa <rei@tetrate.io>

Shikugawa added 2 commits July 1, 2020 15:39

Merge branch 'master' of https://github.com/envoyproxy/envoy into dns…

0aec3e9

…-circuit-breaker Signed-off-by: Shikugawa <rei@tetrate.io>

Kick CI

05834c2

Signed-off-by: Shikugawa <rei@tetrate.io>

mattklein123 approved these changes Jul 1, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Jul 1, 2020

lizan merged commit de247a8 into envoyproxy:master Jul 1, 2020

mattklein123 mentioned this pull request Jan 11, 2021

envoy.reloadable_features.enable_dns_cache_circuit_breakers deprecation #14642

Closed

Conversation

Shikugawa commented May 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented May 1, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

repokitteh-read-only bot commented May 5, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

lizan commented Jun 30, 2020

Uh oh!

Shikugawa commented Jul 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shikugawa commented May 1, 2020 •

edited

Loading