Closed
Conversation
Looks like Bazel 0.5.1 caused the .gcda to appear under runfiles, which confuses gcov as it doesn't match the location of the .gcno.
Member
Author
|
@mattklein123 I need to head out now. This is roughly the fix, but I don't have time to wait for it to verify. Feel free to take over this PR to unblock coverage. |
Member
|
@dnoe can you just merge this fix into your PR so we can test it all together? |
Member
|
As long as this still passes on the old image, can also just merge this. Then merger master into the other PR. Can do it later. |
Contributor
|
I believe this change is independent of mine. There is no expected change to the coverage in my change (death tests never reported coverage for covered lines). Unfortunately this still seems to be failing the coverage test, it looks like there is something else wrong. Let me see what I can find. |
Member
Member
|
Fix merged in @dnoe commit. Closing. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Adds basic framework for unit coverage of the PlatformBridgeFilter. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Adds basic framework for unit coverage of the PlatformBridgeFilter. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Bazel 0.5.1 caused the .gcda to appear under runfiles, which
confuses gcov as it doesn't match the location of the .gcno.