build: refine docker image CI process#10729
Merged
mattklein123 merged 6 commits intomasterfrom Apr 10, 2020
Merged
Conversation
Fixes #10716 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@lizan I tested various permutations of this locally with different env var combinations so I'm fairly confident it works correctly, but would definitely appreciate a close look. |
lizan
reviewed
Apr 10, 2020
Member
lizan
left a comment
There was a problem hiding this comment.
Thanks, a few comment. Also can you apply following so we run postsubmit CI against release branch?
diff --git a/.azure-pipelines/pipelines.yml b/.azure-pipelines/pipelines.yml
index 69338021a0..e60c4b35e9 100644
--- a/.azure-pipelines/pipelines.yml
+++ b/.azure-pipelines/pipelines.yml
@@ -2,6 +2,7 @@ trigger:
branches:
include:
- "master"
+ - "release/v*"
tags:
include:
- "v*"
Member
Author
Yes I will make the change, but see my other comment. I don't think we want to push images for stable branch builds, only for tags. This would be useful for CI though. |
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@lizan updated PTAL. I did not make the one change your requested to push images on release branch build since IMO we don't want that. |
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@lizan updated per offline convo |
lizan
pushed a commit
that referenced
this pull request
May 5, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
pushed a commit
that referenced
this pull request
May 5, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
pushed a commit
that referenced
this pull request
May 5, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10716