doc: updated procedure of adding v2 proto config files for extensions#10667
Closed
cpakulski wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
doc: updated procedure of adding v2 proto config files for extensions#10667cpakulski wants to merge 1 commit intoenvoyproxy:masterfrom
cpakulski wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
option (udpa.annotations.file_status).package_version_status = ACTIVE; must be added. Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Member
|
@cpakulski we're about to switch to v3 being the active API, I'll copy and update your patch into #10636. Thanks for providing this. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 6, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There is a new option required for proto versioning:
option (udpa.annotations.file_status).package_version_status.
Without that option v2 proto config files are not included in a build.
Updated doc describing procedure of adding v2 config files for extensions.
Risk Level:
Low
Testing:
None
Docs Changes:
None
Release Notes:
None