doc: certificate hot-reload for xDS gRPC connection#10628
doc: certificate hot-reload for xDS gRPC connection#10628mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
9c2650f to
14525a3
Compare
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thank for the follow up. A few small comments. Thank you!
/wait
docs/root/intro/version_history.rst
Outdated
There was a problem hiding this comment.
This should work for any SDS setup, right? Meaning this can be used for a standard TLS listener cert rotation and is not specific to xDS? This is a feature request that comes up a ton so can we a) make it clear that this is also supported, and maybe also b) mention this somewhere in https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/ssl with maybe a link to the example you created?
There was a problem hiding this comment.
I might move this into the path docs below? WDYT?
Adds documentation for envoyproxy#10163. Signed-off-by: Tero Saarni <tero.saarni@est.tech>
14525a3 to
a5c483b
Compare
|
@tsaarni friendly request to not ever force push. It makes reviews more difficult. Please only add commits and merge master (note that suggested changes breaks DCO if that is what happened to you, sorry!). Thank you! |
|
@mattklein123 Thanks for review & merge! Sorry for using force push, I will not use it in future! Some projects have not squashed PR commits so I grown a bad habit using it for "clean" history. BTW I've been too focused on my xDS use case to realize that there are other uses for for certificate rotation for static resources outside that 👍Thanks for pointing that out! |
Adds documentation for #10163.
Signed-off-by: Tero Saarni tero.saarni@est.tech