Skip to content

build: use rules_cc#10597

Closed
lizan wants to merge 1 commit intoenvoyproxy:masterfrom
lizan:incompatible_bazel
Closed

build: use rules_cc#10597
lizan wants to merge 1 commit intoenvoyproxy:masterfrom
lizan:incompatible_bazel

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Mar 31, 2020

Description:
Partially address #9488. Almost generated change by applying buildifier -lint=fix.

Risk Level: Low
Testing: local
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou lizan@tetrate.io

@lizan
use rules_cc
86e1d9f 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from htuch March 31, 2020 22:59
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 31, 2020

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10597 was opened by lizan.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member

htuch commented Mar 31, 2020

@lizan can you do a distinct PR with the buildifier linting and add that check to CI? That will make this PR much faster to review.

@htuch htuch self-assigned this Mar 31, 2020
@lizan
Copy link
Copy Markdown
Member Author

lizan commented Mar 31, 2020

@htuch I tried to add that to check format but it doesn't play nice with the envoy_build_fixer.py (around load/license order etc).

@lizan
Copy link
Copy Markdown
Member Author

lizan commented Mar 31, 2020

@htuch FYI only bazel/repositories.bzl and bazel/repository_locations.bzl are manual change.

@htuch
Copy link
Copy Markdown
Member

htuch commented Apr 1, 2020

@lizan envoy_build_fixer.py is using Buildozer. Is this not compatible with buildifier? Are there CLI flags to better align them? We could always add a buildifier pass at the end of envoy_build_fixer.py.

@stale
Copy link
Copy Markdown

stale bot commented Apr 8, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 8, 2020
@lizan lizan removed the stale stalebot believes this issue/PR has not been touched recently label Apr 8, 2020
@stale
Copy link
Copy Markdown

stale bot commented Apr 17, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 17, 2020
@stale
Copy link
Copy Markdown

stale bot commented Apr 25, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Apr 25, 2020
@lizan lizan mentioned this pull request Jun 2, 2020
Merged
lizan added a commit that referenced this pull request Jun 3, 2020
@lizan
build: use rules_cc and use buildifier -lint to enforce it (#11399)
67649af 
Commit Message:
Partially address #9488. Resurrected #10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
aunu53 pushed a commit to aunu53/envoy that referenced this pull request Jun 4, 2020
@lizan
build: use rules_cc and use buildifier -lint to enforce it (envoyprox…
2688edc 
…y#11399)

Commit Message:
Partially address envoyproxy#9488. Resurrected envoyproxy#10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Auni Ahsan <auni@google.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
@lizan @yashwant121
build: use rules_cc and use buildifier -lint to enforce it (envoyprox…
f7c44db 
…y#11399)

Commit Message:
Partially address envoyproxy#9488. Resurrected envoyproxy#10597.

Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htuch htuch Awaiting requested review from htuch

@alyssawilk alyssawilk Awaiting requested review from alyssawilk

@dio dio Awaiting requested review from dio

@jmarantz jmarantz Awaiting requested review from jmarantz

@junr03 junr03 Awaiting requested review from junr03

@mattklein123 mattklein123 Awaiting requested review from mattklein123

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

@snowp snowp Awaiting requested review from snowp

@zuercher zuercher Awaiting requested review from zuercher

Assignees

@htuch htuch

Labels

api stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lizan @htuch