Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
This is pure refactor + reorder, it still shows |
htuch
reviewed
Mar 30, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, I assume the parallelism is not affected (and improved by the guards). Let me know when you are ready to merge.
Member
Author
|
@htuch it affects parallelism a bit because |
htuch
approved these changes
Mar 30, 2020
lizan
added a commit
that referenced
this pull request
May 5, 2020
Description: Merge all platforms into one pipelines to - guard mac and windows CI by format check - guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure. - not guard docker image build by sanitizers. - refactor out bazel steps to another yaml file Risk Level: Low (CI only) Testing: CI Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
added a commit
that referenced
this pull request
May 5, 2020
Description: Merge all platforms into one pipelines to - guard mac and windows CI by format check - guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure. - not guard docker image build by sanitizers. - refactor out bazel steps to another yaml file Risk Level: Low (CI only) Testing: CI Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Merge all platforms into one pipelines to
Risk Level: Low (CI only)
Testing: CI
Docs Changes:
Release Notes: