Skip to content

update retry_policy_typed_config field#10426

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
yxue:fix
Mar 17, 2020
Merged

update retry_policy_typed_config field#10426
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
yxue:fix

Conversation

@yxue
Copy link
Copy Markdown
Member

@yxue yxue commented Mar 17, 2020

Signed-off-by: Yan Xue yxyan@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Yan Xue <yxyan@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10426 was opened by yxue.

see: more, trace.

Copy link
Copy Markdown
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowp
Copy link
Copy Markdown
Contributor

snowp commented Mar 17, 2020

FYI @htuch the previous PR broke master due to something else using the same proto ids getting merged

@yxue yxue changed the title update retry_policy_extension field update retry_policy_typed_config field Mar 17, 2020
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@moderation
Copy link
Copy Markdown
Contributor

Was about to report the following error but looks like this PR resolves:
envoy/api/v2/route/route_components.proto:170:51: Field number 19 has already been used in "envoy.api.v2.route.VirtualHost" by field "include_attempt_count_in_response".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants