lua: allow using moonjit#10265
Conversation
dio
left a comment
There was a problem hiding this comment.
Thanks for this. I think we need to add an entry to docs/root/intro/version_history.rst and docs/root/configuration/http/http_filters/lua_filter.rst to let users aware of it (to try it out).
|
Why not just use a more recent snapshot of luajit instead, which has support for both IBM architectures? |
|
@yselkowitz since this moonjit is an alternative, we can always update luajit "version". |
|
@dio done. @yselkowitz where can I get it? I checked master and v2.1 branches of https://luajit.org/git/luajit-2.0.git, and s390x support is not there. |
|
The OpenResty fork of luajit2 has support for both Power LE and Z in their latest snapshot: |
moonjit (https://github.com/moonjit/moonjit) is a continuation of LuaJIT development, which, as of late, has, unfortunately, come to a stall. In comparison to LuaJIT, moonjit, among other things, supports s390x architecture as well as some of the Lua 5.2 language features. With this patch, moonjit can be enabled using --//source/extensions/filters/common/lua:moonjit=1 bazel flag. Internally, moonjit integration is based on luajit integration. Some of the fragments thereof (e.g. luajit.patch) were copy-pasted with minimal modifications. While arguably ugly, this allows updating LuaJIT and moonjit independently. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
|
@dio done @yselkowitz what looks interesting about OpenResty fork, is that moonjit maintainer also thinks it's the way forward for the Lua community (openresty/luajit2#80). Unfortunately, the merger discussion has somewhat stalled. What also makes it harder for us to quickly evaluate OpenResty fork, is that their test suite is much smaller than that of moonjit. So we would rather go forward with moonjit for the time being, if possible. |
This reverts commit 2c03496. See thread https://twitter.com/siddhesh_p/status/1308594269502885889?s=20 @siddhesh_p Sep 22 "It ought to generally be easy to revert to the upstream tree since they're both [moonjit and luajit] (AFAIK) on the 2.1.x branch. I'll be happy to help with the transition if needed." This is no longer maintained code, there is no way for envoy project to assume responsibility, and after many months, no maintainers have stepped forward. PR's to luajit effort are one appropriate way forward. Resolves: envoyproxy#13539 Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Description:
moonjit (https://github.com/moonjit/moonjit) is a continuation of
LuaJIT development, which, as of late, has, unfortunately, come to
a stall.
In comparison to LuaJIT, moonjit, among other things, supports
s390x architecture as well as some of the Lua 5.2 language
features.
With this patch, moonjit can be enabled using
--//source/extensions/filters/common/lua:moonjit=1
bazel flag.
Internally, moonjit integration is based on luajit integration.
Some of the fragments thereof (e.g. luajit.patch) were copy-pasted
with minimal modifications. While arguably ugly, this allows
updating LuaJIT and moonjit independently.
Signed-off-by: Ilya Leoshkevich iii@linux.ibm.com
Risk Level: Low
Testing: Run tests with
--//source/extensions/filters/common/lua:moonjit=1flagDocs Changes: None
Release Notes: None