route checker tool: differentiate between request and response headers#10168
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Feb 27, 2020
Merged
route checker tool: differentiate between request and response headers#10168mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Member
|
Thanks a ton for fixing this. Can you merge master and then I can review without all the duplicated code? Thank you! /wait |
mattklein123
requested changes
Feb 26, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thanks for tackling this. A few comments. Thank you!
Comment on lines
+44
to
+45
| std::unique_ptr<Http::TestRequestHeaderMapImpl> request_headers_; | ||
| std::unique_ptr<Http::TestResponseHeaderMapImpl> response_headers_; |
Contributor
Author
There was a problem hiding this comment.
I was unable to set these to const since some of the header finalization methods only take non-Const headers as parameters
Contributor
|
/rk-ping |
|
pong |
Contributor
|
/wait |
Contributor
|
unwait please |
Contributor
|
i said unwait! |
|
pong |
Contributor
|
sorry for the noise, debugging repokitteh. please ignore comments by me. |
Signed-off-by: Lisa Lu <lisalu@lyft.com>
mattklein123
approved these changes
Feb 27, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thank you for this!
kb000
pushed a commit
to kb000/envoy
that referenced
this pull request
Mar 6, 2020
envoyproxy#10168) Signed-off-by: Lisa Lu <lisalu@lyft.com> Signed-off-by: Kevin Burek <kburek@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lisa Lu lisalu@lyft.com
Description: This change refactors the route checker tool to strictly differentiate between request and response headers to avoid ambiguity in how headers are specified and tested against for users. Header finalization is now done explicitly and separately for request headers and response headers and performed only once. Users must specify request headers or response headers rather than the previous ambiguous "header_fields" field. This change also eliminates customHeaderFields, which is unneeded with header finalization being performed and which was never publicly documented for use.
Risk Level: Low
Testing: Updated unit tests
Docs Changes: Included
Release Notes: N/A
Deprecated: header_fields, additional_headers, custom_header_fields in validation.proto. Deprecation notes added.