server: expose flushStats() method #10097
Merged
mattklein123 merged 10 commits intoenvoyproxy:masterfrom Feb 25, 2020
junr03:flushstats
Merged
server: expose flushStats() method #10097mattklein123 merged 10 commits intoenvoyproxy:masterfrom junr03:flushstats
mattklein123 merged 10 commits intoenvoyproxy:masterfrom
junr03:flushstats
Conversation
added 2 commits
February 18, 2020 16:21
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
jmarantz
previously approved these changes
Feb 19, 2020
jmarantz
reviewed
Feb 19, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
jmarantz
reviewed
Feb 21, 2020
added 2 commits
February 21, 2020 12:19
Signed-off-by: Jose Nino <jnino@lyft.com>
jmarantz
previously approved these changes
Feb 22, 2020
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
One one-word nit, otherwise lgtm
@envoyproxy/senior-maintainers for a final pass.
jmarantz
previously approved these changes
Feb 22, 2020
Contributor
|
/retest |
|
🔨 rebuilding |
jmarantz
approved these changes
Feb 22, 2020
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Feb 27, 2020
Bumping to include envoyproxy/envoy#10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Feb 27, 2020
Bumping to include envoyproxy/envoy#10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Feb 27, 2020
Adds functionality built on top of the upstream Envoy changes in envoyproxy/envoy#10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Follow-up PRs will call these functions from Java/Objective-C. Part of #573. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Mar 3, 2020
Adds functionality built on top of the upstream Envoy changes in envoyproxy/envoy#10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Note: Stats must be flushed from the main Envoy thread, as validated by the following assertion failure that occurs when attempting to flush from another thread: ``` [2020-02-27 14:38:43.181][4716580][critical][assert] [external/envoy/source/common/thread_local/thread_local_impl.cc:190] assert failure: std::this_thread::get_id() == main_thread_id_. ``` Follow-up PRs will call these functions from Java/Objective-C. Part of #573. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Mar 3, 2020
Adds functionality built on top of the upstream Envoy changes in envoyproxy/envoy#10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Note: Stats must be flushed from the main Envoy thread, as validated by the following assertion failure that occurs when attempting to flush from another thread: ``` [2020-02-27 14:38:43.181][4716580][critical][assert] [external/envoy/source/common/thread_local/thread_local_impl.cc:190] assert failure: std::this_thread::get_id() == main_thread_id_. ``` Follow-up PRs will call these functions from Java/Objective-C. Part of #573. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Mar 3, 2020
Adds functionality built on top of the upstream Envoy changes in envoyproxy/envoy#10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Note: Stats must be flushed from the main Envoy thread, as validated by the following assertion failure that occurs when attempting to flush from another thread: ``` [2020-02-27 14:38:43.181][4716580][critical][assert] [external/envoy/source/common/thread_local/thread_local_impl.cc:190] assert failure: std::this_thread::get_id() == main_thread_id_. ``` Follow-up PRs will call these functions from Java/Objective-C. Part of #573. Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Bumping to include #10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Adds functionality built on top of the upstream Envoy changes in #10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Note: Stats must be flushed from the main Envoy thread, as validated by the following assertion failure that occurs when attempting to flush from another thread: ``` [2020-02-27 14:38:43.181][4716580][critical][assert] [external/envoy/source/common/thread_local/thread_local_impl.cc:190] assert failure: std::this_thread::get_id() == main_thread_id_. ``` Follow-up PRs will call these functions from Java/Objective-C. Part of envoyproxy/envoy-mobile#573. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Bumping to include #10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Adds functionality built on top of the upstream Envoy changes in #10097 which will allow the bridging layers to manually flush stats based on lifecycle changes in the mobile application. Note: Stats must be flushed from the main Envoy thread, as validated by the following assertion failure that occurs when attempting to flush from another thread: ``` [2020-02-27 14:38:43.181][4716580][critical][assert] [external/envoy/source/common/thread_local/thread_local_impl.cc:190] assert failure: std::this_thread::get_id() == main_thread_id_. ``` Follow-up PRs will call these functions from Java/Objective-C. Part of envoyproxy/envoy-mobile#573. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: this PR moves the previously private flushStats method in the server instance to the public interface. This method can be used by consumers to flush stats out-of-band from the stats flushing interval.
In particular it would help API driven consumers like Envoy Mobile to flush relevant stats on-demand. Related issue in Envoy Mobile envoyproxy/envoy-mobile#573
Risk Level: low
Testing: updated mocks. updated
TEST_P(ServerStatsTest, FlushStats)to use the exposed function.Signed-off-by: Jose Nino jnino@lyft.com