coverage: some safeguards to avoid clang silent failure.#1004
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom May 22, 2017
Merged
coverage: some safeguards to avoid clang silent failure.#1004htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
clang isn't compatible with gcov (see envoyproxy#858). We plan to switch to lcov in the future (see envoyproxy#1000). For now, just make sure we fail visibly and document.
Member
Author
rlazarus
approved these changes
May 22, 2017
Contributor
rlazarus
left a comment
There was a problem hiding this comment.
Thanks for digging into this!
Contributor
|
+1 that this solves my coverage failure problem |
Member
Author
|
@junr03 Can I get approval for this? Thanks. |
junr03
approved these changes
May 22, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, there's a bit of race condition where the gateway pod mutation hook can be called before the secret config is created by the Gateway controller. That resulted in blocking the Envoy pods from starting up. This resolves the issue by doing lazy mutation until the secret is created. **Related Issues/PRs (if applicable)** Closes #742 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang isn't compatible with gcov (see #858). We plan to switch to lcov in the future (see #1000).
For now, just make sure we fail visibly and document.