You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: linkstamp is currently used by the VersionInfo class to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:
linkstamp is not available for non-binary rules. Thus if the version_info_lib is compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robust linkstamp mechanism we use for binary rules.
bazel: expand linkstamp beyond binary rules.
Description:
linkstampis currently used by theVersionInfoclass to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:linkstampis not available for non-binary rules. Thus if theversion_info_libis compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robustlinkstampmechanism we use for binary rules.