-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed as not planned
Labels
stalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recentlytech debt
Description
bazel: expand linkstamp beyond binary rules.
Description: linkstamp is currently used by the VersionInfo class to stamp envoy binaries. This is a robust mechanism. However, there are two current problems with it:
- It is poorly documented and understood. Document git workspace SHA1 inclusion in C++ builds bazelbuild/bazel#2893
linkstampis not available for non-binary rules. Thus if theversion_info_libis compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by VersionInfo: allow non-linkstamp rules to link in definitions #6803. However, it would be great to use the same, robustlinkstampmechanism we use for binary rules.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
stalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recentlytech debt