-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Check non-RBE proto_format timing #22483
Copy link
Copy link
Open
Labels
buginvestigatePotential bug that needs verificationPotential bug that needs verificationno stalebotDisables stalebot from closing an issueDisables stalebot from closing an issue
Description
In #21750 #21769 and #21754 various optimizations were made to proto_format
these optimizations were mostly focused on the RBE use case as that is what is used in CI and most core devs have it available. They were also focused on optimizing the incremental use case (at least for protos that are not depended upon by other protos)
its not clear exactly the impact on the non-RBE case - esp where core protos have been changed
for now the workaround is to use CI to run proto_format and generate any required diffs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buginvestigatePotential bug that needs verificationPotential bug that needs verificationno stalebotDisables stalebot from closing an issueDisables stalebot from closing an issue