-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Moving the connection info into a single provider #17168
Copy link
Copy link
Closed
Labels
Description
Title: Moving the connection info into a single provider
Description:
According to the discussion on the PR #16574 (comment), there are connection Infos are coping around which leads to the bug like #14922. So plan to fix this kind of issue using the way like #14133 way: moving those infos into a single provider.
So separate the fix by following steps:
- Moving the server name into SocketAddressProvider (this fix Listener access logs missing %REQUESTED_SERVER_NAME% when no filter chain matches #14922 and tls: moving the server name into SocketAddressProvider #16574)
- Moving the connection id into SocketAddressProvider (this fix by socket: move connection id interface to SocketAddressProvider #17231)
- Moving the ssl info into SocketAddressProvider (this fix by tls: move ssl connection info into SocketAddressProvider #17334)
- Rename SocketAddressProvider to a proper name (this fix by network: rename SocketAddressProvider as ConnectionInfoProvider #17717)
- Removing any code which getting those infos are not from the SocketAddressProvider
Reactions are currently unavailable