docs: add gateway-error as one of retry-on policies#415
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jan 14, 2018
Merged
docs: add gateway-error as one of retry-on policies#415mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Dhi Aurrahman <dio@hooq.tv>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small comment. Thank you for working on this!
| request, including any retries that take place. | ||
|
|
||
| gateway-error | ||
| Envoy will attempt a retry if the upstream server responds with 502, 503 or 504 response code. This policy should have |
Member
There was a problem hiding this comment.
Technically, all of the same documentation applies here as per the "5xx" policy. I would recommend rephrasing in the negative sense. E.g., "This policy is similar to the 5xx policy but will only retry requests that result in a 502, 503, or 504."
Signed-off-by: Dhi Aurrahman <dio@hooq.tv>
| request, including any retries that take place. | ||
|
|
||
| gateway-error | ||
| Envoy will attempt a retry if the upstream server responds with 502, 503, or 504 response code. |
Member
There was a problem hiding this comment.
I would recommend deleting this line. It's similar including the text about disconnect/reset/read-timeout, etc. (This is related to my other comment in the implementation PR). Unless of course you intend it really to be only upstream responses. I assume though you want Envoy origin responses also?
Signed-off-by: Dhi Aurrahman <dio@hooq.tv>
mattklein123
approved these changes
Jan 14, 2018
jrajahalme
added a commit
to jrajahalme/envoy-api
that referenced
this pull request
Jan 16, 2018
docs: add gateway-error as one of retry-on policies (envoyproxy#415)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds doc for adding gateway-error as a retry-on policy, i.e. when the received response code is classified as a gateway error (502, 503 and 504). It is a subset of 5xx.
Ref: envoyproxy/envoy#2300