lds/cds docs: clarify that static listeners/clusters cannot be modified#381
Merged
lds/cds docs: clarify that static listeners/clusters cannot be modified#381
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
This was referenced Jan 2, 2018
htuch
approved these changes
Jan 3, 2018
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jan 3, 2018
To match the behavior of the cluster manager, static listeners should not be modifiable. This creates a large amount of confusion. Risk Level: Low Testing: New UT, also covered by existing unit/integration teests Docs Changes: envoyproxy/data-plane-api#381 Release Notes: N/A (this was broken before and I don't think requires a release note) Fixes #2234 Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Klein mklein@lyft.com