xds_protocol: make explicit that updates only occur when resources ch…#328
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Dec 7, 2017
Merged
xds_protocol: make explicit that updates only occur when resources ch…#328htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
…ange. This comes up a fair bit in discussion with management server implementers, @ramaraochavali suggested we explain this. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
mattklein123
approved these changes
Dec 7, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
It might be worth opening an issue around detecting spinning and/or rate-limiting the number of discovery requests that we send (with strong warning emitted), since I agree this is going to be a very common issue.
Member
Author
|
Issue filed at envoyproxy/envoy#2169. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ange.
This comes up a fair bit in discussion with management server
implementers, @ramaraochavali suggested we explain this.
Signed-off-by: Harvey Tuch htuch@google.com