fix: add OwnerReference for HTTPRouteFilter#888
Merged
mathetake merged 8 commits intoenvoyproxy:mainfrom Jul 15, 2025
Merged
Conversation
Signed-off-by: googs1025 <googs1025@gmail.com>
Signed-off-by: googs1025 <googs1025@gmail.com>
Signed-off-by: googs1025 <googs1025@gmail.com>
e74821a to
8228055
Compare
Signed-off-by: googs1025 <googs1025@gmail.com>
5f52d75 to
7206728
Compare
Signed-off-by: googs1025 <googs1025@gmail.com>
Signed-off-by: googs1025 <googs1025@gmail.com>
fead319 to
1dea5c1
Compare
Signed-off-by: googs1025 <googs1025@gmail.com>
1dea5c1 to
6449c97
Compare
mathetake
reviewed
Jul 14, 2025
| if err := c.client.Get(ctx, client.ObjectKey{Name: base.Name, Namespace: base.Namespace}, &f); err != nil { | ||
| if apierrors.IsNotFound(err) { | ||
| if err = ctrlutil.SetControllerReference(aiGatewayRoute, base, c.client.Scheme()); err != nil { | ||
| return fmt.Errorf("failed to set owner reference for HTTPRouteFilter %s: %w", base.Name, err) |
Member
There was a problem hiding this comment.
this should be a panic just like my comment in another pr
mathetake
reviewed
Jul 14, 2025
tests/controller/controller_test.go
Outdated
Comment on lines
+311
to
+322
| var f egv1a1.HTTPRouteFilter | ||
| err = c.Get(t.Context(), hostRewriteKey, &f) | ||
| if err == nil { | ||
| return true | ||
| } | ||
| if !apierrors.IsNotFound(err) { | ||
| t.Logf("unexpected error when fetching filter %s: %v", hostRewriteKey, err) | ||
| return false | ||
| } | ||
| ok, _ := ctrlutil.HasOwnerReference(f.OwnerReferences, origin, c.Scheme()) | ||
| require.True(t, ok, "expected hostRewriteFilter to have owner reference to AIGatewayRoute") | ||
| return false |
Member
There was a problem hiding this comment.
this is very weird. you are checking if err == nil at the beginning and at the bottom you are checking ownerreference. you should check the owner reference on ok case
Suggested change
| var f egv1a1.HTTPRouteFilter | |
| err = c.Get(t.Context(), hostRewriteKey, &f) | |
| if err == nil { | |
| return true | |
| } | |
| if !apierrors.IsNotFound(err) { | |
| t.Logf("unexpected error when fetching filter %s: %v", hostRewriteKey, err) | |
| return false | |
| } | |
| ok, _ := ctrlutil.HasOwnerReference(f.OwnerReferences, origin, c.Scheme()) | |
| require.True(t, ok, "expected hostRewriteFilter to have owner reference to AIGatewayRoute") | |
| return false | |
| var f egv1a1.HTTPRouteFilter | |
| err = c.Get(t.Context(), hostRewriteKey, &f) | |
| if err != nil { | |
| t.Logf("expected to get hostRewriteFilter %s, but got error: %v", hostRewriteHTTPFilterName, err) | |
| return false | |
| } | |
| ok, _ := ctrlutil.HasOwnerReference(f.OwnerReferences, origin, c.Scheme()) | |
| require.True(t, ok, "expected hostRewriteFilter to have owner reference to AIGatewayRoute") | |
| return true |
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing out that. this was a logic error...
mathetake
reviewed
Jul 14, 2025
Member
There was a problem hiding this comment.
can you add the deletion check in t.Run("delete route", func(t *testing.T) { below?
Contributor
Author
There was a problem hiding this comment.
The envtest.Environment does not seem to have gc deletion. I actually tested it and it seems that does not work.
some issue: kubernetes-sigs/kubebuilder#1175
Signed-off-by: googs1025 <googs1025@gmail.com>
mathetake
approved these changes
Jul 15, 2025
Member
mathetake
left a comment
There was a problem hiding this comment.
Thank you for your contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit add OwnerReference for HTTPRouteFilter when creating
Related Issues/PRs (if applicable)
Fixes: #873
Special notes for reviewers (if applicable)
None