Skip to content

Document lack of controller manager in integration tests#1175

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
pivotal-k8s:doc-garbage-collection
Nov 16, 2019
Merged

Document lack of controller manager in integration tests#1175
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
pivotal-k8s:doc-garbage-collection

Conversation

@mariantalla
Copy link
Copy Markdown
Contributor

@mariantalla mariantalla commented Nov 11, 2019

...and offer one example of how to cover owner relationship in integration
tests.

This is something that has tripped us up quite a bit, maybe there's others.

xref: kubernetes-sigs/controller-runtime#626

cc @hoegaarden

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2019
@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 11, 2019 •
edited
Loading

/kind documentation

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 11, 2019

@mariantalla: The label(s) kind/docs cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

Details

In response to this:

/kind docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 11, 2019
@camilamacedo86
Copy link
Copy Markdown
Member

camilamacedo86 commented Nov 12, 2019

/assign @pmorie

@camilamacedo86
Copy link
Copy Markdown
Member

camilamacedo86 commented Nov 12, 2019

/assign @camilamacedo86

@camilamacedo86
Copy link
Copy Markdown
Member

camilamacedo86 commented Nov 12, 2019

HI @mariantalla,

For this PR pass in the continuous-integration/travis-ci/pr is required to do a rebase with the master in order to get the fix #1168.

camilamacedo86
camilamacedo86 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @pmorie,

The update in the docs shows well for me.
So, /lgtm /approve

WDYT?

@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 13, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@hoegaarden
Document lack of controller manager in integration tests
cdc066f 
...and offer examples of how to cover owner relationship in integration
tests.

Signed-off-by: Hannes Hörl <hhorl@pivotal.io>
@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 13, 2019

/hold cancel
had a bit too much fun rebasing

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@camilamacedo86
Copy link
Copy Markdown
Member

camilamacedo86 commented Nov 13, 2019

/assign @mengqiy

camilamacedo86
camilamacedo86 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pmorie @mengqiy,

This one shows 100% to be merged as well.
WDYT? Could you please help us move forward with?

@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 13, 2019

/retest
The PR is purely docs so I think (hope?) it didn't cause the test failure .

@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 13, 2019

Ah no worries, it's because the prow job config still mentions test_e2e.sh. Looking into that real quick...

@camilamacedo86
Copy link
Copy Markdown
Member

camilamacedo86 commented Nov 13, 2019

Hi @mariantalla

No worry about pull-kubebuilder-e2e it is construction and it is not a blocker for we merge it.

@mariantalla
Copy link
Copy Markdown
Contributor Author

mariantalla commented Nov 13, 2019 •
edited
Loading

/retest

(for the travis build 🤔 )

@mengqiy mengqiy closed this Nov 16, 2019
@mengqiy mengqiy reopened this Nov 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 16, 2019

@mariantalla: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubebuilder-e2e cdc066f link /test pull-kubebuilder-e2e
pull-kubebuilder-test cdc066f link /test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mengqiy
mengqiy approved these changes Nov 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mariantalla, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit dc32e46 into kubernetes-sigs:master Nov 16, 2019
@googs1025 googs1025 mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mengqiy mengqiy mengqiy approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@pmorie pmorie

@mengqiy mengqiy

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mariantalla @k8s-ci-robot @camilamacedo86 @mengqiy @pmorie