chore: enable codespell check#48
Conversation
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
b2f747b to
549ef5f
Compare
| @@ -0,0 +1 @@ | |||
| ./manifests/charts/ai-gateway-helm/crds/* | |||
There was a problem hiding this comment.
if this is needed, then the spell check seems not running properly on the code comments in api.go? Since the typo maxmimum in api.go is the reason why https://github.com/envoyproxy/ai-gateway/actions/runs/12387688325/job/34577531455 is failing, we should fix the go file rather than ignoring the generated file.
There was a problem hiding this comment.
This comes from the upstream Gateway HTTPRoute and has been fixed in kubernetes-sigs/gateway-api#3380.
However, we need this workaround until the Gateway API is upgraded to the next version.
Besides, the generated CRDs can be safely ingnored because the original spell errors will always be found in the API source code first.
There was a problem hiding this comment.
aha ok, now that makes sense... thank you for clarifying huabing!
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Fixes: #28