extproc: remove noise when reloading config#392
Merged
mathetake merged 2 commits intoenvoyproxy:mainfrom Feb 20, 2025
Merged
Conversation
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
mathetake
reviewed
Feb 20, 2025
mathetake
approved these changes
Feb 20, 2025
mathetake
added a commit
that referenced
this pull request
Feb 21, 2025
**Commit Message** There was a race condition in extproc package's TestStartConfigWatcher test. **Related Issues/PRs (if applicable)** Follow up on #392 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
extproc: remove noise when reloading config
Reduce the noise when configuration is reloaded. Only print logs when the configuration actually changes and do not reload the default config on every tick.
Related Issues/PRs (if applicable)
Related to #376
Special notes for reviewers (if applicable)
N/A