Skip to content

chore: remove nip.io now that EG supports localhost backends in cli#1501

Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom
nacx:remove-nip-io
Nov 11, 2025
Merged

chore: remove nip.io now that EG supports localhost backends in cli#1501
mathetake merged 1 commit intoenvoyproxy:mainfrom
nacx:remove-nip-io

Conversation

@nacx
Copy link
Copy Markdown
Member

@nacx nacx commented Nov 6, 2025

Description

Now that EG has merged the patch that allows using localhost in Backends when running in standalone mode, we can remove the uses of .nip.io we were using to overcome the limitation when proxying local Ollama LLMs or local MCP servers.

I've verified all Docker guides we had as well as all ollama configs and everything works as expected (cc @codefromthecrypt)

Related Issues/PRs (if applicable)

envoyproxy/gateway#7427

Special notes for reviewers (if applicable)

This requires upgrading to the latest EG from main (the change hasn't yet been cherry-picked to the 1.6 release branch). Opening as a draft to avoid bumping the EG dependency beyond 1.6 until we release.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.92%. Comparing base (21cc0e4) to head (3308267).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
- Coverage   83.93%   83.92%   -0.01%     
==========================================
  Files         144      144              
  Lines       12670    12663       -7     
==========================================
- Hits        10635    10628       -7     
  Misses       1419     1419              
  Partials      616      616              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nacx
Copy link
Copy Markdown
Member Author

nacx commented Nov 6, 2025

/retest

Copy link
Copy Markdown
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great and this doesn't just solve the auto-config (ENV driven) mode, but also config in general. The first time I tried aigw, I lost many hours trying not knowing there were tricks needed just to use localhost. That time was before we had auto-config so it was just a really obscure pitfall in the normal yaml.

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <nacx@apache.org>
@nacx nacx marked this pull request as ready for review November 11, 2025 15:37
@nacx nacx requested a review from a team as a code owner November 11, 2025 15:37
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 11, 2025
@nacx
Copy link
Copy Markdown
Member Author

nacx commented Nov 11, 2025

The change in EG is released and this is ready for review and merge

@codefromthecrypt
Copy link
Copy Markdown
Contributor

thanks I am really happy you did this

@mathetake
Copy link
Copy Markdown
Member

/retest

@mathetake mathetake enabled auto-merge (squash) November 11, 2025 16:28
@mathetake mathetake merged commit 99dc630 into envoyproxy:main Nov 11, 2025
49 of 51 checks passed
hustxiayang pushed a commit to hustxiayang/ai-gateway that referenced this pull request Nov 13, 2025
…nvoyproxy#1501)

**Description**

Now that EG has merged the patch that allows using `localhost` in
Backends when running in standalone mode, we can remove the uses of
`.nip.io` we were using to overcome the limitation when proxying local
Ollama LLMs or local MCP servers.

I've verified all Docker guides we had as well as all ollama configs and
everything works as expected (cc @codefromthecrypt)

**Related Issues/PRs (if applicable)**

envoyproxy/gateway#7427

**Special notes for reviewers (if applicable)**

This requires upgrading to the latest EG from main (the change hasn't
yet been cherry-picked to the 1.6 release branch). Opening as a draft to
avoid bumping the EG dependency beyond 1.6 until we release.

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <nacx@apache.org>
Signed-off-by: yxia216 <yxia216@bloomberg.net>
missBerg pushed a commit to missBerg/ai-gateway that referenced this pull request Dec 20, 2025
…nvoyproxy#1501)

**Description**

Now that EG has merged the patch that allows using `localhost` in
Backends when running in standalone mode, we can remove the uses of
`.nip.io` we were using to overcome the limitation when proxying local
Ollama LLMs or local MCP servers.

I've verified all Docker guides we had as well as all ollama configs and
everything works as expected (cc @codefromthecrypt)

**Related Issues/PRs (if applicable)**

envoyproxy/gateway#7427

**Special notes for reviewers (if applicable)**

This requires upgrading to the latest EG from main (the change hasn't
yet been cherry-picked to the 1.6 release branch). Opening as a draft to
avoid bumping the EG dependency beyond 1.6 until we release.

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <nacx@apache.org>
Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants