refactor: remove /crds folder from ai-gateway-helm chart#1431
Merged
nacx merged 1 commit intoenvoyproxy:mainfrom Oct 24, 2025
Merged
refactor: remove /crds folder from ai-gateway-helm chart#1431nacx merged 1 commit intoenvoyproxy:mainfrom
nacx merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: sailesh duddupudi <saileshradar@gmail.com>
dd8d152 to
7a34ce8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (78.63%) is below the target coverage (86.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 139 139
Lines 13764 13764
=======================================
Hits 10824 10824
Misses 2285 2285
Partials 655 655 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
missBerg
pushed a commit
to missBerg/ai-gateway
that referenced
this pull request
Dec 20, 2025
…1431) **Description** As discussed in this slack thread: https://envoyproxy.slack.com/archives/C07Q4N24VAA/p1761235915409479, we want to separate the crd chart and the resources chart. (option 1 of the proposed approaches in envoyproxy#1186) **Related Issues/PRs (if applicable)** envoyproxy#1186 **Special notes for reviewers (if applicable)** Added an extra note on upgrade when done from a previous install of ai-gateway-helm helm chart alone. it uses the `--take-ownership` flag while upgrading: helm/helm#13439, https://helm.sh/docs/helm/helm_upgrade/#options Open Question: - Should we rename `ai-gateway-helm` to `ai-gateway-resources-helm`? It would be more consistent but upgrade is slightly trickier cc: @mathetake @johnugeorge @nagar-ajay Signed-off-by: sailesh duddupudi <saileshradar@gmail.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in this slack thread: https://envoyproxy.slack.com/archives/C07Q4N24VAA/p1761235915409479, we want to separate the crd chart and the resources chart. (option 1 of the proposed approaches in #1186)
Related Issues/PRs (if applicable)
#1186
Special notes for reviewers (if applicable)
Added an extra note on upgrade when done from a previous install of ai-gateway-helm helm chart alone. it uses the
--take-ownershipflag while upgrading: helm/helm#13439, https://helm.sh/docs/helm/helm_upgrade/#optionsOpen Question:
ai-gateway-helmtoai-gateway-resources-helm? It would be more consistent but upgrade is slightly trickiercc: @mathetake @johnugeorge @nagar-ajay