Skip to content

feat: support gcp service account key file and gcp doc #1090

Merged
mathetake merged 16 commits intoenvoyproxy:mainfrom
yuzisun:gcp_doc
Aug 21, 2025
Merged

feat: support gcp service account key file and gcp doc #1090
mathetake merged 16 commits intoenvoyproxy:mainfrom
yuzisun:gcp_doc

Conversation

@yuzisun
Copy link
Copy Markdown
Contributor

@yuzisun yuzisun commented Aug 17, 2025 •
edited by mathetake
Loading

Description
Added the support for GCP static service account credential file for an easier way to show case how to access GenAI models on GCP VertexAI.

Related Issues/PRs (if applicable)
Fixes #1015
Closes #609

@yuzisun yuzisun changed the title feat: support gcp service account credential file and add gcp doc feat: support gcp service account key file and gcp doc Aug 17, 2025
@mathetake mathetake added this to the v0.3.0 milestone Aug 18, 2025
mathetake
mathetake reviewed Aug 18, 2025
View reviewed changes
mathetake
mathetake reviewed Aug 18, 2025
View reviewed changes
mathetake
mathetake reviewed Aug 18, 2025
View reviewed changes
yuzisun
yuzisun commented Aug 20, 2025
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.25000% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.75%. Comparing base (a6917fe) to head (1995617).

Files with missing lines Patch % Lines
internal/controller/backend_security_policy.go 26.92% 38 Missing ⚠️
internal/controller/rotators/gcp_token_rotator.go 66.21% 22 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   78.19%   77.75%   -0.44%     
==========================================
  Files          84       86       +2     
  Lines        9689     9809     +120     
==========================================
+ Hits         7576     7627      +51     
- Misses       1750     1817      +67     
- Partials      363      365       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yuzisun
yuzisun commented Aug 20, 2025
View reviewed changes
@yuzisun yuzisun marked this pull request as ready for review August 20, 2025 01:03
@yuzisun yuzisun requested a review from a team as a code owner August 20, 2025 01:03
mathetake
mathetake reviewed Aug 20, 2025
View reviewed changes
mathetake
mathetake reviewed Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mathetake
mathetake reviewed Aug 20, 2025
View reviewed changes
yuzisun added 10 commits August 20, 2025 15:20
@yuzisun
add supported endpoints
db366cd 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
update security credentials doc
fd3c7e2 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
GCP vertex AI connect doc
c6eaade 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
support gcp service account credential file
1998b6e 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
update comment
a706139 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
update security policy example file
716b831 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
update gcp examples doc
e4e64f6 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
add tests for gcp sa credential file
9903cb6 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
move loading credential file to handler constructor
5730f59 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
add gcp token rotator
e5ab671 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
yuzisun and others added 5 commits August 20, 2025 15:27
@yuzisun
add Anthropic target ref
1fee0a1 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
Update backend_security_policy.go
1b31a9a 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
fix tests
79b896f 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@yuzisun
fix doc
d6edffd 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@mathetake
schema no longer needed
bdfd966 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
mathetake approved these changes Aug 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mathetake mathetake merged commit da86fc6 into envoyproxy:main Aug 21, 2025
26 checks passed
missBerg pushed a commit to missBerg/ai-gateway that referenced this pull request Dec 20, 2025
@yuzisun @missBerg
feat: support gcp service account key file and gcp doc (envoyproxy#1090)
e2f4c2d 
**Description**
Added the support for GCP static service account credential file for an
easier way to show case how to access GenAI models on GCP VertexAI.

**Related Issues/PRs (if applicable)**
Fixes envoyproxy#1015
Closes envoyproxy#609

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathetake mathetake mathetake approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

GCP integration: add connect-providers page Support GCP models

3 participants

@yuzisun @codecov-commenter @mathetake