Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Jan 16, 2025
Member
Author
|
cc @envoyproxy/ai-gateway-assignable |
Member
Author
|
will do the e2e tests in another PR |
mathetake
commented
Jan 16, 2025
yuzisun
reviewed
Jan 16, 2025
Member
Author
|
marking as draft until all ready including tests |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
|
ok ready - I would like to unblock #111 so I will defer the end to end tests in a subsequent PR. |
Member
Author
|
also CEL implementation is TODO as it will be a relatively large change |
mathetake
commented
Jan 17, 2025
Comment on lines
+117
to
120
| for k, v := range r.Header { | ||
| fmt.Printf("header %q: %s\n", k, v) | ||
| } | ||
| if v := r.Header.Get(expectedHeadersKey); v != "" { |
Member
Author
There was a problem hiding this comment.
note: intentionally left as the testupstream does this elsewhere everywhere
yuzisun
reviewed
Jan 17, 2025
yuzisun
reviewed
Jan 17, 2025
yuzisun
reviewed
Jan 17, 2025
aabchoo
reviewed
Jan 17, 2025
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Jan 17, 2025
Member
Author
|
ready 🎵 |
mathetake
commented
Jan 18, 2025
yuzisun
approved these changes
Jan 18, 2025
This was referenced Jan 18, 2025
mathetake
added a commit
that referenced
this pull request
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the RequestCost field to AIGatewayRoute,
which will allows users to do the rate limiting etc
based on the calculated "token usage".
This is based on the new feature introduced in
and because of the feature, the only thing we have to do
from AI Gateway side is to set a dynamic metadata as per
the comment in the API.