Remaining issues/abstraction cleanup#10
Closed
enoch85 wants to merge 47 commits into
Closed
Conversation
…verId instead of plexId
Owner
Author
|
Progress! These collections are migrated from Plex, and running the rules on them in Jellyfin produces the same collections in Jellyfin. 🎉 
|
Owner
Author
|
@jessielw I'm finally done now! Feel free to test and report back. 👍 |
Owner
Author
|
Closing in favor of consolidated PR #24 (jellyfin-dev branch). All changes are included there. |
enoch85
added a commit
that referenced
this pull request
Jan 31, 2026
…apters - Document error handling contract in IMediaServerService interface: - Read operations return empty/undefined on failure - Write operations throw with descriptive message - Add try/catch with logging to Plex adapter write operations - Improve error messages to include context (collection ID, item ID, etc.) Fixes review item #10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to be the last one which will cleanup the code, and look for anything more that we might want/need to abstract.
This PR will also be the one I run in my PROD to test everything from now on. I plan to try to break everything and find all the bugs.