fix(pass-style): no symbol named methods in remotables#2779
Merged
erights merged 8 commits intomarkm-flip-which-symbols-are-passablefrom Apr 28, 2025
Merged
fix(pass-style): no symbol named methods in remotables#2779erights merged 8 commits intomarkm-flip-which-symbols-are-passablefrom
erights merged 8 commits intomarkm-flip-which-symbols-are-passablefrom
Conversation
2 tasks
56915b8 to
99687cb
Compare
99687cb to
57586e2
Compare
This was referenced Apr 27, 2025
2874801 to
0ad0e4b
Compare
Contributor
Author
Contributor
Author
|
Putting into Draft until we have time to discuss this approach. |
Contributor
Author
b01af20
into
markm-flip-which-symbols-are-passable
15 checks passed
erights
added a commit
that referenced
this pull request
Apr 28, 2025
Staged on #2777 Closes: #XXXX Refs: #XXXX ## Description No more symbol named methods in remotable. Needed for #2777 to make sense. But a separate PR for now because it causes more errors to investigate. ### Security Considerations > Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls? ### Scaling Considerations > Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated? ### Documentation Considerations > Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users? ### Testing Considerations > Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet? ### Compatibility Considerations > Does this change break any prior usage patterns? Does this change allow usage patterns to evolve? ### Upgrade Considerations > What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed? > Include `*BREAKING*:` in the commit message with migration instructions for any breaking change. > Update `NEWS.md` for user-facing changes. > Delete guidance from pull request description before merge (including this!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged on #2777
Closes: #XXXX
Refs: #XXXX
Description
No more symbol named methods in remotable. Needed for #2777 to make sense. But a separate PR for now because it causes more errors to investigate.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations