Skip to content

fix(pass-style): no symbol named methods in remotables#2779

Merged
erights merged 8 commits intomarkm-flip-which-symbols-are-passablefrom
markm-no-symbol-named-methods
Apr 28, 2025
Merged

fix(pass-style): no symbol named methods in remotables#2779
erights merged 8 commits intomarkm-flip-which-symbols-are-passablefrom
markm-no-symbol-named-methods

Conversation

@erights
Copy link
Copy Markdown
Contributor

@erights erights commented Apr 27, 2025

Staged on #2777

Closes: #XXXX
Refs: #XXXX

Description

No more symbol named methods in remotable. Needed for #2777 to make sense. But a separate PR for now because it causes more errors to investigate.

Security Considerations

Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls?

Scaling Considerations

Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated?

Documentation Considerations

Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users?

Testing Considerations

Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet?

Compatibility Considerations

Does this change break any prior usage patterns? Does this change allow usage patterns to evolve?

Upgrade Considerations

What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed?

Include *BREAKING*: in the commit message with migration instructions for any breaking change.

Update NEWS.md for user-facing changes.

Delete guidance from pull request description before merge (including this!)

@erights erights self-assigned this Apr 27, 2025
@erights erights force-pushed the markm-no-symbol-named-methods branch from 56915b8 to 99687cb Compare April 27, 2025 01:42
@erights erights force-pushed the markm-no-symbol-named-methods branch from 2874801 to 0ad0e4b Compare April 27, 2025 04:56
@erights
Copy link
Copy Markdown
Contributor Author

erights commented Apr 28, 2025

Reviewers, does anyone mind if I squash this differential PR #2779 and then merge it into #2777 ?

@erights
Copy link
Copy Markdown
Contributor Author

erights commented Apr 28, 2025

Putting into Draft until we have time to discuss this approach.

@erights erights marked this pull request as draft April 28, 2025 22:49
@erights
Copy link
Copy Markdown
Contributor Author

erights commented Apr 28, 2025

Reviewers, does anyone mind if I squash this differential PR #2779 and then merge it into #2777 ?

Putting into Draft until we have time to discuss this approach.

Now that this is in draft in order to postpone discussion, I'm going to do a bunch of squashing as well as merging #2779 PR into #2777

@erights erights marked this pull request as ready for review April 28, 2025 23:43
@erights erights merged commit b01af20 into markm-flip-which-symbols-are-passable Apr 28, 2025
15 checks passed
@erights erights deleted the markm-no-symbol-named-methods branch April 28, 2025 23:43
erights added a commit that referenced this pull request Apr 28, 2025
Staged on #2777

Closes: #XXXX
Refs: #XXXX

## Description

No more symbol named methods in remotable. Needed for #2777 to make
sense. But a separate PR for now because it causes more errors to
investigate.

### Security Considerations

> Does this change introduce new assumptions or dependencies that, if
violated, could introduce security vulnerabilities? How does this PR
change the boundaries between mutually-suspicious components? What new
authorities are introduced by this change, perhaps by new API calls?

### Scaling Considerations

> Does this change require or encourage significant increase in
consumption of CPU cycles, RAM, on-chain storage, message exchanges, or
other scarce resources? If so, can that be prevented or mitigated?

### Documentation Considerations

> Give our docs folks some hints about what needs to be described to
downstream users. Backwards compatibility: what happens to existing data
or deployments when this code is shipped? Do we need to instruct users
to do something to upgrade their saved data? If there is no upgrade path
possible, how bad will that be for users?

### Testing Considerations

> Every PR should of course come with tests of its own functionality.
What additional tests are still needed beyond those unit tests? How does
this affect CI, other test automation, or the testnet?

### Compatibility Considerations

> Does this change break any prior usage patterns? Does this change
allow usage patterns to evolve?

### Upgrade Considerations

> What aspects of this PR are relevant to upgrading live production
systems, and how should they be addressed?

> Include `*BREAKING*:` in the commit message with migration
instructions for any breaking change.

> Update `NEWS.md` for user-facing changes.

> Delete guidance from pull request description before merge (including
this!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant