EReturn type#2659
Merged
Merged
Conversation
michaelfig
approved these changes
Dec 12, 2024
michaelfig
left a comment
Member
There was a problem hiding this comment.
LGTM! This is a good utility to make available.
I pushed some other changes to dedupe @endo/far type aliases and export EReturn from that package as well. PTAL and feel free to merge when satisfied.
mergify Bot
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jan 29, 2025
## Description While working on another PR, I had to type out `ReturnType<Awaited<ReturnType<` again and I wished for a utility type. This PR first made an `ExoObj` type but has changed to use `EReturn` now available in Endo. - endojs/endo#2659 ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Not necessary ### Testing Considerations CI ### Upgrade Considerations n/a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incidental
Description
Migrated from Agoric/agoric-sdk#9011
Define an
EReturntype for theAwaited<ReturnType<pattern.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
This will appear in TSdoc
Testing Considerations
has tests
Compatibility Considerations
none
Upgrade Considerations
none