Upgrade Babel 7.23#1893
Conversation
|
Nit title: 7.23 not 2.23 |
Fixed 
|
4e9c2c4 to
a19939b
Compare
mhofman
left a comment
There was a problem hiding this comment.
Please run a npx yarn-deduplicate
| "types": "./types.d.ts", | ||
| "import": "./index.js", | ||
| "require": "./dist/ses.cjs", | ||
| "types": "./types.d.ts" |
There was a problem hiding this comment.
The "types" changes seem unrelated
There was a problem hiding this comment.
It is. This was a byproduct of running ./scripts/set-versions.sh, which went ahead and removed the duplicate key from this package.json.
There was a problem hiding this comment.
(and I’m retaining an individual commit for this change so it’s easy to identify/remove/move. I’ll accommodate your preference. Mine is to preserve the commit and save time.)
There was a problem hiding this comment.
Oh I missed the duplication!
a19939b to
2be21c8
Compare
Done. |
mhofman
left a comment
There was a problem hiding this comment.
After dedup, the diff of the yarn.lock looks as expected. If tests pass, we should be good to go.
PS: to double check, you ran yarn install after npx yarn-deduplicate to make sure the yarn.lock was stable?
| "types": "./types.d.ts", | ||
| "import": "./index.js", | ||
| "require": "./dist/ses.cjs", | ||
| "types": "./types.d.ts" |
There was a problem hiding this comment.
Oh I missed the duplication!
I did not and it was not stable. Please see the new commit. |
closes: #1846
Description
This should put #1846 to bed. The latest patch releases for Babel have addressed the property override mistake observed while bundling under lockdown.
As evidence, integrating this branch into Agoric SDK Agoric/agoric-sdk#8514 obviates the need to run the bundler with overrideTaming: severe.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations