Sync Endo 2023-11#8514
Conversation
436b99e to
7b43ada
Compare
b212093 to
bb068f6
Compare
2d73d09 to
b693ab6
Compare
b693ab6 to
ee5f04b
Compare
|
|
69801d4 to
21a95f0
Compare
erights
left a comment
There was a problem hiding this comment.
Approving FWIW. You should probably still wait for another reviewer.
| t.is(passStyleOf(facet), 'remotable'); | ||
| t.deepEqual(Object.getOwnPropertyNames(facet), []); | ||
| t.deepEqual( | ||
| Object.getOwnPropertyNames(facet).filter(name => !name.startsWith('__')), |
There was a problem hiding this comment.
Factor out reusable testing helper?
| await t.throwsAsync(() => E(zoe).getPublicFacet(), { | ||
| message: | ||
| /In "getPublicFacet" method of \(ZoeService\): arg 0: .*"\[undefined\]" - Must be a remotable/, | ||
| // Or pattern of golden error tolerant across versions of endo. |
There was a problem hiding this comment.
I know I wrote this horrible sentence, but how about
| // Or pattern of golden error tolerant across versions of endo. | |
| // Golden test uses RegExp "Or" pattern to tolerate earlier versions of endo |
Likewise below
| const seat = makeZCFSeat(); | ||
| t.deepEqual(getStringMethodNames(seat), expectedStringMethods.sort()); | ||
| t.deepEqual( | ||
| getStringMethodNames(seat).filter(name => !name.startsWith('__')), |
There was a problem hiding this comment.
If you create reusable testing helper for these, see if you can use it here too.
There was a problem hiding this comment.
It’s my preference to keep tests readable at the expense of repetition. In this case, I believe the code is offering an explanation.
| /** @type {import('.').Zone['exoClass']} */ | ||
| const exoClass = (...args) => prepareExoClass(baggage, ...args); | ||
| /** @type {import('.').Zone['exoClassKit']} */ | ||
| // @ts-ignore This type check regressed inexplicably with the release |
There was a problem hiding this comment.
I see lint gave you the expected second order error. I have suppressed this either with another @ts-ignore or an eslint-disable-next-line . I forget which. In any case, I suspect plenty of these remain in the code.
21a95f0 to
d9f61b4
Compare
763092b to
98e6c2b
Compare
98e6c2b to
454c83e
Compare
454c83e to
477003b
Compare
477003b to
8b1e82e
Compare
|
Subsumed this into #8651 which goes on to sync up with published Endo versions. |
|
I can also close #8642 as subsumed, yes? |
No description provided.