Merged
Conversation
Rotate the spawned scene according to the SimpleSpawner node global rotation. Useful for changing the direction of bullets spawned from a rotated object.
Remove the spawn_parent property and only leave the "SCENE" behavior. Document this as part of the class documentation.
dylanmccall
reviewed
Oct 28, 2024
dylanmccall
approved these changes
Oct 31, 2024
Contributor
Author
Should we just go with this? I think we already gave enough time for early feedback. |
Contributor
|
Yeah, let's see what we hear back after the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #292
Instead of adding yet another property, make the "rotate with spawner" the default. Also remove the "spawn parent" property to leave only the SCENE behavior (as a separate commit).