Merged
Conversation
Greptile SummaryThis PR fixes a regression where
Confidence Score: 5/5Safe to merge; the core resolution path change mirrors the existing internal The No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(cli): skip registry for workspace de..." | Re-trigger Greptile |
9acad10 to
a5280b2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the workspace dependency regression reported in Discussion #520.
aube updateresolution soworkspace:deps frompackage.json#workspacesresolve locallyworkspace:root dependencies inaube outdatedValidation
cargo fmt --checkcargo check -p aubecargo build -p aubemise run test:bats test/update.batsmise run test:bats test/outdated.batsThis PR was generated by Codex.
Note
Medium Risk
Changes dependency resolution and registry-fetch behavior in
aube update/aube outdated, which can affect what versions are selected and when the CLI exits early. Risk is mitigated by targeted regression tests for workspaceworkspace:specs.Overview
Fixes a regression where
workspace:dependencies frompackage.json#workspacescould trigger unnecessary registry lookups and fail to resolve locally.aube updatenow discovers workspace packagename/versionpairs and passes them into resolver workspace resolution (with a newWARN_AUBE_WORKSPACE_PACKAGE_MISSING_NAMEwhen a workspace package lacksname).aube outdatednow filters out direct deps whose specifier isworkspace:so it reports “no matching dependencies” instead of attempting packument fetches.Adds Bats regression tests covering both commands when the only dependency is an unpublished workspace package.
Reviewed by Cursor Bugbot for commit a5280b2. Bugbot is set up for automated code reviews on this repo. Configure here.