Adapt test_response_decode_text_using_autodetect for chardet 6.0#3773
Merged
Conversation
lovelydinosaur
approved these changes
Feb 23, 2026
lovelydinosaur
left a comment
Contributor
There was a problem hiding this comment.
There's more we could say about this, though... yep. Thanks
3 tasks
musicinmybrain
added a commit
to musicinmybrain/httpx2
that referenced
this pull request
Jun 2, 2026
See encode/httpx#3773, which was merged into httpx before httpx2 was forked; this commit extends that approach to tests that were added in httpx2.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See #3772. Version 6.0.0 of
chardetdetects this byte string asWINDOWS-1252, while previous versions detectedISO-8859-1. Since both are plausible (the encoded byte string decodes to the same Unicode string under either encoding), this PR adjusts the test to accept either claim.Checklist