Skip to content

types-certifi and types-chardet are no longer needed#3015

Merged
lovelydinosaur merged 1 commit intoencode:masterfrom
mtelka:types
Dec 21, 2023
Merged

types-certifi and types-chardet are no longer needed#3015
lovelydinosaur merged 1 commit intoencode:masterfrom
mtelka:types

Conversation

@mtelka
Copy link
Contributor

@mtelka mtelka commented Dec 21, 2023

Summary

Both certifi and chardet now contains typing info so we no longer need types-certifi and types-chardet.
See also #3014

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.

@lovelydinosaur lovelydinosaur merged commit 1d526a0 into encode:master Dec 21, 2023
@lovelydinosaur lovelydinosaur added the tooling Changes to our CI/CD, tests setup, etc. label Dec 21, 2023
@mtelka mtelka deleted the types branch December 21, 2023 10:56
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Changes to our CI/CD, tests setup, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants