Move configuration of tools to pyproject.toml#2686
Merged
lovelydinosaur merged 2 commits intoencode:masterfrom May 3, 2023
Secrus:move-configs
Merged
Move configuration of tools to pyproject.toml#2686lovelydinosaur merged 2 commits intoencode:masterfrom Secrus:move-configs
lovelydinosaur merged 2 commits intoencode:masterfrom
Secrus:move-configs
Conversation
Kludex
approved these changes
Apr 29, 2023
Kludex
reviewed
May 1, 2023
| # Tests & Linting | ||
| black==23.3.0 | ||
| coverage==7.2.2 | ||
| coverage[toml]==7.2.2 |
Contributor
There was a problem hiding this comment.
is it to be able to read from the pyproject?
Contributor
Author
There was a problem hiding this comment.
exactly. from what I have seen, coverage requires toml extra to work with pyproject.toml configs.
Contributor
|
Since we've removed flake8 (which was the only project holding this change), I think this is a good change. 👍 |
Contributor
|
Same PR welcome on other encode projects. 👀 🙏 |
Contributor
Author
Sure, give me a moment ;) |
1 task
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
I have noticed that the tools configured by
setup.cfgfile are the ones that can be configured inpyproject.tomlwhich already held some of the tools configurations. Sincesetup.cfgis inherently connected withsetuptoolswhich is not used in this project. I didn't see a need for a discussion in this case.