Skip to content

Use ruff instead of flake8, autoflake and isort#2648

Merged
Kludex merged 4 commits intomasterfrom
refactor/use-ruff
Apr 5, 2023
Merged

Use ruff instead of flake8, autoflake and isort#2648
Kludex merged 4 commits intomasterfrom
refactor/use-ruff

Conversation

@Kludex
Copy link
Copy Markdown
Contributor

@Kludex Kludex commented Apr 4, 2023

Ref.: #2607

@Kludex Kludex force-pushed the refactor/use-ruff branch from 4a7e81a to 7e5f310 Compare April 4, 2023 10:28
@Kludex Kludex requested a review from lovelydinosaur April 4, 2023 10:30
assert response.status_code == 200
with pytest.raises(httpx.ResponseNotRead):
response.content
response.content # noqa: B018
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I track down what a B018 is?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b

Should I add a comment here or ignore it globally?

assert response.status_code == 200
with pytest.raises(httpx.ResponseNotRead):
response.content
response.content # noqa: B018
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b

Should I add a comment here or ignore it globally?

@Kludex Kludex requested a review from lovelydinosaur April 5, 2023 09:35
@Kludex Kludex merged commit daec2bd into master Apr 5, 2023
@Kludex Kludex deleted the refactor/use-ruff branch April 5, 2023 10:37
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
* Use ruff instead of flake8, autoflake and isort

* Update pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants